Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing info: at what time "today's" image is created? #26

Open
EmmanueleVilla opened this issue Jul 30, 2019 · 2 comments
Open

Missing info: at what time "today's" image is created? #26

EmmanueleVilla opened this issue Jul 30, 2019 · 2 comments

Comments

@EmmanueleVilla
Copy link

As per title, when the change in what day is "today" happens?
Looking at the code, it seems that datetime.today().date() returns the local datetime, so what local is that?

@brianthomas
Copy link
Member

brianthomas commented Aug 1, 2019 via email

@MarcusOtter
Copy link
Contributor

MarcusOtter commented Oct 31, 2019

To double check this, I set up automated tests for my wrapper to run every 30 minutes over night, starting from minute 15. The tests started failing when my local time passed 00:00 and started working again at 04:00 UTC, so the APOD seems to be published at 00:00 UTC-4 (Eastern Time).

Last failing test (03:46:49 UTC)
First passing test (04:16:38 UTC)

Perhaps the time zone information should be added to the README.

EDIT: Remember DST.

Time period start Time period end Time of publication
Second Sunday in March First Sunday in November 00:00 UTC-04:00
First Sunday in November Second Sunday in March 00:00 UTC-05:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants