Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POSI fixes #182

Merged
merged 2 commits into from
Oct 26, 2019
Merged

POSI fixes #182

merged 2 commits into from
Oct 26, 2019

Conversation

jason-watkins
Copy link
Contributor

  • Add check to SetPosition to return early if all values are defaults. (This might happen with a POSI command that specifies orientations but not positions)
  • Add check to SetOrientation to return early if all values are defaults
  • Fix a bug in HandlePosi where the gear value was being read incorrectly
  • Also updates the syntax for the position copy to something that's ARM compatible
  • Fixes the code in Message to print the value of the POSI command

@jason-watkins jason-watkins changed the title Posi defaults POSI fixes Oct 18, 2019
@jason-watkins jason-watkins mentioned this pull request Oct 18, 2019
Closed
@teubert teubert merged commit 52b034d into develop Oct 26, 2019
@jason-watkins jason-watkins mentioned this pull request Jun 27, 2020
Merged
@jason-watkins jason-watkins deleted the posi-defaults branch June 29, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teubert teubert teubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-watkins @teubert