Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.2.1 #103

Merged
merged 34 commits into from
May 3, 2017
Merged

V1.2.1 #103

merged 34 commits into from
May 3, 2017

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Apr 24, 2017

Various bugfixes, namely:

  • SetPosition now updates the aircraft's orientation after moving the aircraft, should improve performance
  • Fixed Sudden aircraft crash after "pauseSim" command (Sudden aircraft crash after "pauseSim" command #91)
  • Replaced istrue with isequal in Matlab client
  • Fixed use of incorrect readData java call in Matlab readData function
  • Removed use of C99 for-loop initialization in c client
  • Removed unused dead-code
  • Updated Copyright year
  • Replaced incorrect use of time.h with sys/time.h for Linux/Mac
  • Fixed error checking in c readData function
  • Updated C client test project to build on VS 2015
  • Fixed typo in readDATA error message

teubert and others added 23 commits May 6, 2015 10:39
…oes not know the istrue() function. Further the java readData() function was misspelled.
[xDATA]: fix non working Data gathering functions in MATLAB. Matlab d…
# Conflicts:
#	xpcPlugin/XPlaneConnect/mac.xpl
#	xpcPlugin/xpcPlugin.xcodeproj/project.pbxproj
# Conflicts:
#	C/src/xplaneConnect.c
#	xpcPlugin/XPlaneConnect/mac.xpl
#	xpcPlugin/xpcPlugin.xcodeproj/project.pbxproj
 - SetPosition now updates the aircraft's orientation after moving the aircraft
 - This should improve the handling of the aircraft when setting the position while paused and then unpausing
 - Fixes #91
@teubert
Copy link
Contributor Author

teubert commented Apr 24, 2017

Tested on Red Hat Linux v6.9, OS X 10.11.6, and Windows 7.

@jason-watkins
Copy link
Contributor

I get a few tests failing on Windows 10 that I don't really have time to dig into. Are you seeing all tests pass for the C client on Windows 7?

@jason-watkins
Copy link
Contributor

Also, what's the reason for commit 9bb5f99? Curious what platform isn't allowing variable declaration inside the loop, but accepts mixed declarations and initializations.

@teubert
Copy link
Contributor Author

teubert commented May 2, 2017

@jason-watkins: Thanks for testing this out on your machine. Sorry for the delay, I was on travel. Now I'm back and can look further into this.

I'm pretty sure all the tests passed for the C Client on Windows 7, I will double check later. Can you tell me which tests are failing on Windows 10.

Also 9bb5f99 was added specifically for Red Hat. The setup for the group's server was giving this error.

@teubert
Copy link
Contributor Author

teubert commented May 2, 2017

@jason-watkins I have a theory!

Are you getting the errors "[getDREFs] ERROR: Read operation failed."? If so, it seems that the tests are being sent faster than XPCPlugin can handle them. In that case we have it clear the message buffer (close and open the sockets). When this happens, those messages are lost and I receive those error messages.

I'm occasionally receiving these messages testing on mac. Unfortionately, If we dont have it reset the socket, either the sim will fall far behind (if we keep the per cycle message limit), or the sim could freeze (if we remove the limit) or run very slow. Adding a small delay between the tests fixes this issue for the test, but we should think about ways we could notify the user that too many commands are being received (maybe a message on the screen). Let's discuss that this summer.

In the meantime, when you have some free time could you try the unit tests I just checked in and let me know if that change fixes the issue you were having with the tests?

teubert and others added 2 commits May 2, 2017 16:56
Fixed issue with c tests running too fast (overwhelming plugin)
@jason-watkins
Copy link
Contributor

With the latest commit, every test passes except for the VIEW test, which I think has never actually worked.

I did need to tweak the window.h include in Test.h to compile successfully in Visual Studio 2015.

All in all, I am comfortable merging this.

@teubert
Copy link
Contributor Author

teubert commented May 3, 2017

Great. Thanks, @jason-watkins. I realize though that commit 10f3ce2 changes the plugin code, so this now needs updated Linux and Windows binaries. I'll try to provide those and rerun the tests today.

@teubert teubert merged commit 2bd6eec into master May 3, 2017
@teubert teubert deleted the v1.2.1 branch May 3, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants