Fix #353, correct PSP module IDs and lookups #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the CFE_PSP_Module_FindByName and CFE_PSP_Module_GetAPIEntry lookups to use the correct length of the config data 'PspModuleList'. The internal variable that had been used reflected the total across two lists and thus was not a correct limit. Rather than having these functions search both lists, this instead keeps it to only exposing the user-specified modules in PspModuleList, it does not expose the built-in/base modules. This makes the change simpler, as typically the built in modules would not be accessed through these functions at all.
|
This also fixes #319 (same bug, different description) |
skliper
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 5, 2022
*Combines:* psp v1.6.0-rc4+dev47 **Includes:** - nasa/PSP#354, correct PSP module IDs and lookups Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 5, 2022
*Combines:* psp v1.6.0-rc4+dev47 **Includes:** - nasa/PSP#354, correct PSP module IDs and lookups Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Correct the CFE_PSP_Module_FindByName and CFE_PSP_Module_GetAPIEntry lookups to use the correct length of the config data 'PspModuleList'.
The internal variable that had been used reflected the total across two lists and thus was not a correct limit.
Rather than having these functions search both lists, this instead keeps it to only exposing the user-specified modules in PspModuleList, it does not expose the built-in/base modules. This makes the change simpler, as typically the built in modules would not be accessed through these functions at all.
Fixes #353
Testing performed
Boot CFE and confirm modules being initialized as expected. Confirm that module lookup is working and returning correct module ID.
Expected behavior changes
System(s) tested on
Ubuntu 22.04
Additional context
This PR does not currently add a coverage test for this code, although that should be considered as a follow on.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.