Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared workflow scripts need updates for node.js version #429

Closed
chillfig opened this issue May 1, 2024 · 0 comments · Fixed by #430
Closed

Shared workflow scripts need updates for node.js version #429

chillfig opened this issue May 1, 2024 · 0 comments · Fixed by #430

Comments

@chillfig
Copy link
Contributor

chillfig commented May 1, 2024

Describe the bug
actions/checkout@v3 in https://github.com/nasa/PSP/blob/main/.github/workflows/icbundle.yml uses node.js version 16, which is now deprecated.

To Reproduce
Manual inspection

Expected behavior
No warnings in github workflows mentioning deprecated node.js versions

Code snips

uses: actions/checkout@v3

System observed on:

  • OS: Ubuntu 20.04

Additional context
Copy of concern in nasa/cFS#742
This modified workflow may be obsolete/never used? https://github.com/nasa/PSP/actions/workflows/icbundle.yml

Reporter Info
Justin Figueroa, Vantage Systems

@chillfig chillfig added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration labels May 1, 2024
@chillfig chillfig self-assigned this May 1, 2024
@chillfig chillfig removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 1, 2024
dzbaker added a commit that referenced this issue May 6, 2024
Fix #429, Adds node20 compatible github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant