Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting Issues with ICBundle Workflow #399

Closed
dzbaker opened this issue Aug 9, 2023 · 0 comments
Closed

Formatting Issues with ICBundle Workflow #399

dzbaker opened this issue Aug 9, 2023 · 0 comments

Comments

@dzbaker
Copy link
Contributor

dzbaker commented Aug 9, 2023

Describe the bug
Similar to nasa/cFE#2419. There are some small formatting issues that should be corrected in the changelog/version.h updates made by the ICBundle workflow:

  1. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/mcp750-vxworks/inc/psp_version.h
  2. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/pc-linux/inc/psp_version.h
  3. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/pc-rtems/inc/psp_version.h

To Reproduce
Steps to reproduce the behavior:

  1. Push a code change to a user-owned feature branch
  2. Submit a pull request for that code change
  3. Go to the "Actions" tab in GitHub and run the "Integration Candidate Bundle Generation" workflow with the PR number as the input argument for the field labeled "The pull request numbers to include (Comma separated):"
  4. Wait for the workflow to complete
  5. Inspect the newly updated/generated "integration-candidate branch"
  6. Observe the changes made to the fsw/mcp750-vxworks/inc/psp_version.h, fsw/pc-linux/inc/psp_version.h, and fsw/pc-rtems/inc/psp_version.h files by the workflow

Expected behavior

  1. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/mcp750-vxworks/inc/psp_version.h
  2. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/pc-linux/inc/psp_version.h
  3. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/pc-rtems/inc/psp_version.h

System observed on:
GitHub

Reporter Info
Dylan Z. Baker/NASA GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants