recommended lgtm issues:

[avan989]

Is your feature request related to a problem? Please describe.
Recommended issue from lgtm:

cfe_psp_module.h

typedef enum
--
37 | {
  | In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.
38 | CFE_PSP_MODULE_TYPE_INVALID = 0,
39 | CFE_PSP_MODULE_TYPE_VALID_RANGE  = 1000,

[skliper]

Definitely worth clarifying.

PSP/fsw/shared/cfe_psp_module.h

Lines 36 to 43 in 502e83a

	typedef enum
	{
	CFE_PSP_MODULE_TYPE_INVALID = 0,
	CFE_PSP_MODULE_TYPE_VALID_RANGE = 1000,
	CFE_PSP_MODULE_TYPE_SIMPLE,
	/* May be extended in the future */
	CFE_PSP_MODULE_TYPE_MAX
	} CFE_PSP_ModuleType_t;

Should be understandable at a quick glance. @jphickey any suggestions? Not clear to me what the intent is here.

[jphickey]

It is simply intended to provide unique(-ish) numeric values for the valid enumerators. If every enumeration in the system starts with 1, then it is easy to interchange. Using a starting value other than 1 offers a modicum of protection against using incorrect values (i.e. if someone passed a pointer to the wrong struct, or something).

I'm not sure why this is an lgtm "issue" as it is pretty well defined in the C standard how enum declarations work. But if you'd rather start with 1, it won't change the behavior, but it will make it a little less secure.