Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated #include of "cfe_platform_cfg.h" #67

Closed
2 tasks done
chillfig opened this issue Jan 30, 2024 · 3 comments · Fixed by #68
Closed
2 tasks done

Deprecated #include of "cfe_platform_cfg.h" #67

chillfig opened this issue Jan 30, 2024 · 3 comments · Fixed by #68
Assignees
@chillfig
Labels
enhancement

Comments

@chillfig
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
The practice of #include "cfe_platform_cfg.h" has been deprecated. Applications should not be dependent on a specific CFE platform configuration

To Reproduce
Manually inspect

Expected behavior
Remove all `#include "cfe_platform_cfg.h"

Code snips

MD/fsw/src/md_verify.h

Line 28 in fe60ebc

#include "cfe_platform_cfg.h"

System observed on:
N/A

Additional context
N/A

Reporter Info
Justin Figueroa, Vantage Systems
@chillfig chillfig self-assigned this Jan 30, 2024
chillfig pushed a commit to chillfig/MD that referenced this issue Jan 30, 2024
Fix nasa#67, Removes cfe platform config dependency
6d65490
@chillfig chillfig mentioned this issue Jan 30, 2024
Merged
2 tasks
@thnkslprpt
Copy link
Contributor

@chillfig
FYI Justin - also 1 case in the LC app

@chillfig
Copy link
Contributor Author

@chillfig FYI Justin - also 1 case in the LC app

Good catch. Thank you!

@chillfig
Copy link
Contributor Author

Issue created for LC: nasa/LC#108

dzbaker added a commit that referenced this issue Feb 1, 2024
@dzbaker
Merge pull request #68 from chillfig/remove_cfeInc
f61b53e 
Fix #67, Removes cfe platform config dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #67, Removes cfe platform config dependency chillfig/MD
2 participants
@thnkslprpt @chillfig