Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine consecutive, mutually-exclusive status checks #52

Closed
2 tasks done
thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #53
Closed
2 tasks done

Combine consecutive, mutually-exclusive status checks #52

thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #53

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
md_app.c contains a couple of consecutive, mutually exclusive status checks.

Code snips

MD/fsw/src/md_app.c

Lines 188 to 197 in 116d298

if (Status != CFE_SUCCESS)
{
CFE_ES_WriteToSysLog("MD_APP:Call to CFE_EVS_Register Failed:RC=%d\n", Status);
}
/*
** Set up for Software Bus Services
*/
if (Status == CFE_SUCCESS)
{

MD/fsw/src/md_app.c

Lines 274 to 283 in 116d298

if (Status != CFE_SUCCESS)
{
CFE_EVS_SendEvent(MD_CREATE_PIPE_ERR_EID, CFE_EVS_EventType_ERROR, "Failed to create pipe. RC = %d", Status);
}
/*
** Subscribe to Housekeeping request commands
*/
if (Status == CFE_SUCCESS)
{

Expected behavior
Combine into an if/else - no need to do 2 evaluations.

Reporter Info
Avi Weiss @thnkslprpt

dzbaker added a commit that referenced this issue May 4, 2023
…ive-status-checks

Fix #52, Combine consecutive, mutually-exclusive status checks
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants