Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #36, Refactor LC_TableInit to remove multiple returns #68

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Jan 30, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI Build + Run, Unit Tests all passing successfully.

Expected behavior changes
Essentially no change to logic.
Previous early return exit points will now fail all the following tests for if (Result == CFE_SUCCESS) and fall through to the end of the function, where Result is returned.

Contributor Info
Avi Weiss @thnkslprpt

Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dzbaker dzbaker merged commit 7a75a36 into nasa:main Apr 27, 2023
@thnkslprpt thnkslprpt deleted the fix-36-refactor-tableinit branch April 27, 2023 20:38
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple return statements in LC_CreateTaskCDS and LC_TableInit
4 participants