Fix #66, correct buffer overflows in UT #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default size of the "EventText" string is 32, but the unit test had hard coded string sizes of 50 chars, which will overflow the buffer. Use "sizeof" operator to adjust to the actual size of the destination to correct the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The default size of the "EventText" string is 32, but the unit test had hard coded string sizes of 50 chars, which will overflow the buffer.
Use "sizeof" operator to adjust to the actual size of the destination to correct the issue.
Fixes #66
Testing performed
Steps taken to test the contribution:
Expected behavior changes
No more buffer overflow
System(s) tested on
Debian Bookworm
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.