Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #43, Remove redundant/inconsistent comments (/* end of function */, /* end if */ etc.) and clean up empty lines. #44

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 9, 2022

Checklist

Describe the contribution
Fixes #43
Removes redundant and inconsistent comments (e.g. /* end of function */)
There were also a few cases of unnecessary empty lines (e.g. on the last line before the closing brace of a function) and also missing empty lines (e.g. between functions) which were corrected. Some of these empty lines trigger the CI format checks.
I've left the commits separated for now to make life easier for whoever reviews this. I can squash them if/when this is ready for merge.

Testing performed
None (comment and whitespace changes only).

Expected behavior changes
No impact on behavior.
These updates will reduce clutter and inconsistency in the code, improving readability.

Contributor Info
@thnkslprpt

@dzbaker
Copy link
Contributor

dzbaker commented Oct 13, 2022

@thnkslprpt CCB 13 October 2022: Approved pending squash of commits and ensuring that commit message follows format.

@thnkslprpt thnkslprpt force-pushed the fix-43-comment-and-empty-line-cleanup branch from a2a446a to 9f55e65 Compare October 13, 2022 21:04
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 13 October 2022: Approved pending squash of commits and ensuring that commit message follows format.

Squashed those together now mate.

@thnkslprpt thnkslprpt force-pushed the fix-43-comment-and-empty-line-cleanup branch 2 times, most recently from df956e3 to a84fa72 Compare October 13, 2022 22:45
@thnkslprpt thnkslprpt force-pushed the fix-43-comment-and-empty-line-cleanup branch from a84fa72 to cf8173d Compare October 13, 2022 22:47
@dzbaker dzbaker self-requested a review October 17, 2022 11:58
@dzbaker dzbaker merged commit 543cf6b into nasa:main Oct 17, 2022
@thnkslprpt thnkslprpt deleted the fix-43-comment-and-empty-line-cleanup branch October 17, 2022 20:41
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant comments (/* end of function */, /* end if */ etc.) and clean up empty lines.
3 participants