Fix #43, correct declaration of CF_CFDP_PlaybackDir_ #69
Conversation
This helper function was declared with fixed-length string arguments but in practice is used with other buffer lengths. These arguments are changed to (more conventional) const char * instead. Note that other cases where fixed-length string arguments are used are not changed by this commit, since it appears those are always used with a buffer of that length.
|
@jphickey - did you mean to delete nasa:main and close this PR? I thought the plan was to transition to "main" as the development branch. |
|
@skliper - Resubmitted in #70. Yes, intent is to change from master -> main but this has to be done by someone w/permission to do so. In the meantime, I realized that having "main" already exist is bad, because github UI only seems to have an option to rename the master branch, and then it complains if there is already a branch named main (learned by doing this to one of my repos). It also makes it more tedious to submit new PRs to a non-default branch, and people who clone this won't get the latest branch, all sorts of nuisances. So in the meantime, yes I deleted main, and hopefully someone will rename master->main in the near future. |
This helper function was declared with fixed-length string arguments but in practice is used with other buffer lengths. These arguments are changed to (more conventional)
const char *instead.Note that other cases where fixed-length string arguments are used are not changed by this commit, since it appears those are always used with a buffer of that length.