Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-3210 Distraction Free Timezone Fix #5320

Merged
merged 2 commits into from
Jul 1, 2024
Merged

WV-3210 Distraction Free Timezone Fix #5320

merged 2 commits into from
Jul 1, 2024

Conversation

christof-wittreich
Copy link
Contributor

Description

This change adds logic to the KioskTimeStamp component to correctly list UTC as the timezone when in distraction free mode.

How To Test

  1. git checkout wv-3210-df-timezone-label
  2. npm ci
  3. npm run watch
  4. Open this link (distraction free mode) and verify that the time is correct and lists it as UTC
  5. Open this link (kiosk mode) and verify that the change does not affect kiosk mode and it still displays in EDT

@christof-wittreich christof-wittreich added this to the v4.42.0 milestone Jun 28, 2024
@christof-wittreich christof-wittreich self-assigned this Jun 28, 2024
@christof-wittreich christof-wittreich merged commit 919ffa0 into develop Jul 1, 2024
4 checks passed
christof-wittreich added a commit that referenced this pull request Jul 2, 2024
@christof-wittreich @PatchesMaps @minniewong
Release to Main v4.42.0 (#5324)
9e62e78 
* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>
christof-wittreich added a commit that referenced this pull request Jul 2, 2024
@christof-wittreich @PatchesMaps @minniewong
Release to Main v4.42.0 (#5324) (#5325)
78f70f4 
* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>
christof-wittreich added a commit that referenced this pull request Jul 10, 2024
@christof-wittreich @PatchesMaps @minniewong
Main to Develop v4.43.0 (#5338)
0ae1902 
* UAT-v4.42.0

* Release to Main v4.42.0 (#5324)

* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* v4.43.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>
christof-wittreich added a commit that referenced this pull request Jul 22, 2024
@christof-wittreich @PatchesMaps @minniewong
Release to Main v4.44.0 (#5361)
469a805 
* Main to Develop v4.43.0 (#5338)

* UAT-v4.42.0

* Release to Main v4.42.0 (#5324)

* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* v4.43.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* Dependency Updates 07-12-234 (#5345)

* Added check for non BEST layers in build (#5333)

* WV-3104 GIBS API Link in Embed Tab (#5340)

* Added api docs link

* Simplified to a single class

* WV-3154 Replace Social Tab with Citation Tab (#5346)

* Changed the social tab to the citation tab

* Changed citation to cite us & modified intro text

* Fixed test

* WV-3242 index out of bounds error (#5332)

* only insert layers at valid index

* only reload when new palette is AERONET

* reload layers on change to rendered palettes

* Dependency Updates 07-19-2024 (#5358)

* Dependency Updates 07-19-2024

* revert sass bump

* WV-3220 Smaller Extent BBox For Finding High-Resolution Imagery (#5347)

* Added smallerExtent

* Added getSmallerExtent reusable function

* WV-3218: Update welcome.md to point users to the Worldview Image of the Week (#5359)

* Update welcome.md

* open link in new tab

* v4.44.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>
christof-wittreich added a commit that referenced this pull request Jul 22, 2024
@christof-wittreich @PatchesMaps @minniewong
Main to Develop v4.44.0 (#5362)
86b9265 
* UAT-v4.42.0

* Release to Main v4.42.0 (#5324)

* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* v4.43.0

* Release to Main v4.44.0 (#5361)

* Main to Develop v4.43.0 (#5338)

* UAT-v4.42.0

* Release to Main v4.42.0 (#5324)

* WV-3177: Rename EOSDIS Worldview to NASA Worldview (#5316)

* Remove EOSDIS

* Update EOSDIS to ESDIS and LANCE acronyms

* Updated eslint-plugin-n (#5317)

* dependency updates

* WV-3210 Distraction Free Timezone Fix (#5320)

* Added kioskMode check for timezone label

* Separated ternary statements

* Update IMERG to version 7 (#5321)

* UAT-v4.42.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* v4.43.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* Dependency Updates 07-12-234 (#5345)

* Added check for non BEST layers in build (#5333)

* WV-3104 GIBS API Link in Embed Tab (#5340)

* Added api docs link

* Simplified to a single class

* WV-3154 Replace Social Tab with Citation Tab (#5346)

* Changed the social tab to the citation tab

* Changed citation to cite us & modified intro text

* Fixed test

* WV-3242 index out of bounds error (#5332)

* only insert layers at valid index

* only reload when new palette is AERONET

* reload layers on change to rendered palettes

* Dependency Updates 07-19-2024 (#5358)

* Dependency Updates 07-19-2024

* revert sass bump

* WV-3220 Smaller Extent BBox For Finding High-Resolution Imagery (#5347)

* Added smallerExtent

* Added getSmallerExtent reusable function

* WV-3218: Update welcome.md to point users to the Worldview Image of the Week (#5359)

* Update welcome.md

* open link in new tab

* v4.44.0

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>

* Merge branch 'develop'

---------

Co-authored-by: Patrick Moulden <[email protected]>
Co-authored-by: minniewong <[email protected]>
Co-authored-by: PatchesMaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatchesMaps PatchesMaps PatchesMaps approved these changes

@minniewong minniewong minniewong approved these changes

@Tomcariello Tomcariello Tomcariello approved these changes

Assignees

@christof-wittreich christof-wittreich

Labels
None yet
Projects
None yet
Milestone
v4.42.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christof-wittreich @PatchesMaps @minniewong @Tomcariello