WV-3111 Kiosk Mode Logo Reset #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatchesMaps
approved these changes
May 31, 2024
|
This works however the logo appears as a link when hovered with the "Click to Reset..." popup language which isn't ideal. Can we eliminate the anchor tag entirely in this scenario so the logo is not a hyperlink at all? |
Tomcariello
reviewed
Jun 4, 2024
minniewong
approved these changes
Jun 7, 2024
Tomcariello
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This disables the ability to click the Worldview logo at the top of the sidebar to reset the worldview instance.
How To Test
git checkout wv-3111-kiosk-logo-disablenpm cinpm run build