WV-3190 Smallest Subdaily Timeline Interval

[christof-wittreich]

Description

This code change changes the behavior of the timeline interval for subdaily layers. Firstly, it allows for subdaily layers to set a custom interval of something other than 10 minutes, and secondly, if multiple subdaily layers are present and have multiple custom intervals, the smallest interval is chosen.

How To Test

1. git checkout wv-3190-smallest-interval-subdaily
2. npm ci
3. npm run watch
4. Open a fresh worldview instance and add a subdaily layer with a custom interval of something other than 10 minutes, like VIIRS_NOAA20_CorrectedReflectance_TrueColor_Granule.
5. Verify that the timeline interval correctly reflects the custom interval.
6. Add another subdaily layer, with a different custom interval than the first subdaily layer added, like Himawari_AHI_Air_Mass.
7. Verify that the timeline interval correctly reflects the smaller of the two custom intervals.
8. Repeat the process with the same layers in a new worldview instance, but add the second layer from before first. Verify the behavior is the same.

[minniewong]

If you add a layer that has a custom interval (like a Level 2 TEMPO layer) then remove it, the interval selector now says "1440 minutes". Would be better if it went back to "1 Day".

[Tomcariello]

I would refactor this to only call lodashGet(layers[i], 'dateRanges[0].dateInterval') once.

 for (let i = 0; i < layers.length; i += 1) {
   let interval = lodashGet(layers[i], 'dateRanges[0].dateInterval');
   if (layers[i].period === 'subdaily' && interval < smallestDelta) {
     smallestDelta = Number(interval);
   }
 }
}

[Tomcariello]

I'd prefer if we clearly define the 1440 value for readability sake.

if (subDailyCountChanged) {
  const isSubDaily = newCustomDelta !== 1440; // or < 1440, if that makes more sense
  if (isSubDaily) {
    changeCustomInterval(newCustomDelta, TIME_SCALE_TO_NUMBER.minute);
  } else {
    changeCustomInterval(1, TIME_SCALE_TO_NUMBER.day);
  }
}