Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-3003 In-Browser Translation Crashing Fix #5220

Merged
merged 1 commit into from
May 30, 2024
Merged

WV-3003 In-Browser Translation Crashing Fix #5220

merged 1 commit into from
May 30, 2024

Conversation

christof-wittreich
Copy link
Contributor

Description

This fix adds the notranslate tag to the specific problem element to prevent it from being translated by the Google Translate browser extension.

How To Test

  1. git checkout wv-3003-translation-extension-fix
  2. npm ci
  3. npm run watch
  4. Go to Worldview using Chrome and install Google Translate
  5. Click on "translate this page" and change to another language
  6. Click on "Add Layers", under Fires, Click on "Aerosol Optical Depth" and add the first layer (MODIS Combined Value-Added Aerosol Optical Depth)
  7. Verify that no error occurs and that the app doesn't crash

@christof-wittreich christof-wittreich self-assigned this May 22, 2024
@minniewong minniewong added this to the v4.39.0 milestone May 29, 2024
@christof-wittreich christof-wittreich merged commit 79f8ce1 into develop May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatchesMaps PatchesMaps PatchesMaps approved these changes

@minniewong minniewong minniewong approved these changes

@Tomcariello Tomcariello Awaiting requested review from Tomcariello

Assignees

@christof-wittreich christof-wittreich

Labels
None yet
Projects
None yet
Milestone
v4.39.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christof-wittreich @PatchesMaps @minniewong