WV-2398: Fix iOS browser crashes #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanweiler92
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes were introduced in OL 6.14.2 that causes browsers to crash on iOS for us after reaching a certain number of layers rendered. See openlayers/openlayers#14171
The inclusion of the
classNameproperty when creating layers on our end prevents canvas re-use between layers which causes a large performance hit, leading to the crash on iOS devices. RemovingclassNamefixes the issue.How To Test
npm ciYou will need to find a way to hit your local dev server from an iOS device, such as using a reverse proxy like ngrok. This error did not seem to happen in simulated devices and definitely won't occur in a desktop browser set to mobile size.