Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-2427: Drop python 2 check #3984

Merged
merged 1 commit into from
Sep 26, 2022
Merged

WV-2427: Drop python 2 check #3984

merged 1 commit into from
Sep 26, 2022

Conversation

jasontk19
Copy link
Collaborator

Description

  • Drop python 2 check, assume python 3
  • Update pipenv version to latest

How To Test

  • npm run python
  • Confirm latest pipenv and dependencies install succesfully
  • npm run build
  • npm run start
  • Confirm app loads and works as expected

@jasontk19
WV-2427
6b3c6be 
* Drop python 2 check, assume python 3
* Update pipenv version to latest
@jasontk19 jasontk19 added this to the v3.33.0 milestone Sep 23, 2022
@jasontk19 jasontk19 self-assigned this Sep 23, 2022
ryanweiler92
ryanweiler92 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@ryanweiler92 ryanweiler92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

Tomcariello
Tomcariello approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Tomcariello Tomcariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me on my system which does not have Python 2 installed. Looks good!

@jasontk19 jasontk19 merged commit 76c5ccd into develop Sep 26, 2022
@jasontk19 jasontk19 deleted the wv-2427 branch September 26, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomcariello Tomcariello Tomcariello approved these changes

@ryanweiler92 ryanweiler92 ryanweiler92 approved these changes

Assignees

@jasontk19 jasontk19

Labels
None yet
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jasontk19 @Tomcariello @ryanweiler92