Social sharing feature #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added link shortening on social sharing click, if there is an error, the default worldview link will be passed. - Formatted sharing text on each platform. - Added schema.org meta tags to index page for passing in information about the page and image to be used.
- Removed warning messages related to not being able to shorten link when clicking a share icon because if it fails, it will just use the full link. No warning needed since there is no direct user action.
- Created new image of share button & replaced font icon within tour.
Benjaki2
reviewed
Jul 13, 2017
| // If selected during the animation, the cursor will go to the | ||
| // end of the input box | ||
| var updateLink = function() { | ||
| $('#permalink_content').val(models.link.get()); |
There was a problem hiding this comment.
I wouldn't do any selecting of react components outside of react. e.g. Pass a state into the component that Focuses the element. This way we are decoupling the component from Worldview and Jquery (maybe we can dispose of it in the future) @ZachTRice
this.state = {
focused: true,
selected: 'idk'
}
- Moved URL Shortener component back into WV until dialog boxes are converted to react.
|
@ZachTRice looks good! Just need to release a new version of WVC and update the package.json with that version. |
Benjaki2
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #140
Connects to #139
Connects to #60
**This feature needs to be tested on Master to ensure URL shortening is working properly. On UAT, Twitter & Email links will appear as the full link in the message fields but on Master these should be shortened links.