Layer search descriptions #368
Conversation
- Fetched static description to active sidebar layer.
Changes relate to Issues #65 & #316 Added an "i" icon, styled Created wv.layers.info.js utility for creating a dialog box containing the layer description Created css file to style elements within this dialog box-sizing Added logic for toggling the description panel Closed dialoag box when resizing window to responsive view from desktop
- Overflowed jquery ui dialog defaults scrollbar to bottom of page, added check after modal opens to force scroll to top. - Removed css rule, set fixed height within dialog
- Matching layer.id to display the category/source description.
Relates to Issue #317
- Had to tweak css to add html element to class selectors to override bank.css default link state.
- Added new header wrapper in layer, so that clicking the expanded description won't check the checkbox, only the initial header row will
web/js/layers/wv.layers.modal.js
Outdated
| @@ -367,7 +367,7 @@ wv.layers.modal = wv.layers.modal || function(models, ui, config) { | |||
| redoScrollbar(); | |||
| $selectedCategory.iCheck({checkboxClass: 'icheckbox_square-red'}); | |||
| $breadcrumb.show(); | |||
|
|
|||
| }; | |||
|
|
|||
| var drawAllLayers = function() { | |||
There was a problem hiding this comment.
@ZachTRice I would work on breaking this method up into smaller functions and add some documentation to the new methods/functions in this component. Ideally we could generate docs using http:https://usejsdoc.org in the future
There was a problem hiding this comment.
I have worked on breaking up most of the methods in this file and documenting with jsdoc. drawMeasurements is tough one to break up further since the HTML for this view is built by finding the current category, looping through it, building the measurement html, appending that, finding the nested sources, appending that, and finding the descriptions and appending that to build the full view.
|
@ZachTRice looks like some conflicts need to be resolved |
|
@Benjaki2 conflicts are now resolved |
Includes search-descriptions and layer-descriptions branches
Connects to #316
connects to #317