Layer descriptions #329
Layer descriptions #329
Conversation
- Fetched static description to active sidebar layer.
Changes relate to Issues #65 & #316 Added an "i" icon, styled Created wv.layers.info.js utility for creating a dialog box containing the layer description Created css file to style elements within this dialog box-sizing Added logic for toggling the description panel Closed dialoag box when resizing window to responsive view from desktop
- Overflowed jquery ui dialog defaults scrollbar to bottom of page, added check after modal opens to force scroll to top. - Removed css rule, set fixed height within dialog
- Matching layer.id to display the category/source description.
web/index.html
Outdated
| </div> | ||
| <div id="selected-category"> | ||
|
|
There was a problem hiding this comment.
I'd leave out these excess lines if there isn't anything inside the divs <div></div> (nit pick)
There was a problem hiding this comment.
I agree. This is how it is currently on master, though I should have cleaned it up while I was working in this area. I'm not sure why git is picking this up as a change.
There was a problem hiding this comment.
Ah, the differences is that there were spaces after the line return that are no longer present.
There was a problem hiding this comment.
ahhh makes sense. Thanks for cleaning up those spaces.
There was a problem hiding this comment.
I requested a couple minor minor style changes, Me being nit picky.... Overall looks really good @ZachTRice !
web/js/layers/wv.layers.info.js
Outdated
| renderDescription($dialog); | ||
|
|
||
|
|
||
| var names = models.layers.getTitles(layer.id); |
There was a problem hiding this comment.
declare vars at top of scope
var loaded = function(custom) {
var names;
| .attr("id", "wv-layers-info-dialog") | ||
| .attr("data-layer", layer.id); | ||
| renderDescription($dialog); | ||
|
|
- Had to tweak css to add html element to class selectors to override bank.css default link state.
|
Thanks, I appreciate the nit picky! Couple things I added to that last commit. Removed a At some point, I'd also like to remove as much element.class selector's as possible. Just to make scoping and compartmentalizing the css a bit easier. |
|
Wait till after next release to merge |
|
Closing this PR because this feature will be merged into a new branch with search-descriptions. The new combined feature branch will then have a PR into development. |
Layer descriptions contained within am "i" button in the sidebar. If no description is available a disabled "i" button is shown. If a description is available, clicking the "i" button expands a modal box. The "i" button and modal box are only available within the desktop view.
Connects to #65
connects to #316