-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhauled GIS and map library sections #8
Conversation
…nks, and validate remaining content
Integrating latest features into GIS and Map Library branch
…verhauling the Google Earth section
…nks, and validate remaining content
…verhauling the Google Earth section
…-gibs/gibs-api-docs into gis-and-map-library-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to be on the whole! I wondered if some of the images needed image captions e.g. Worldview image snapshot and the OpenLayers with GIBS imagery image.
The intro page needs the two new sections added to it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see the markdown target=blank
syntax getting used. It all looks good to me. My only though is that we should make sure that any unused docs (e.g. visualization-generation.md
) gets removed before this goes live, so unwanted info isn't found via the search.
Comments/questions/on the gis-usage page: General
QGIS
ESRI ArcGIS Pro
ESRI ArcGIS/ArcMap
ESRI ArcGISOnline
|
…n add it to the other pages. Updated note to be an admonition Updated intro text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments above
Thanks for your suggestions @minniewong, I've just finished making updates which should address them. |
@Benjaki2 thanks for your review and agreed about the unused docs... though will defer that kind of update until we do a full review of the entire set. |
I can still see users trying to use WMTS given that it’s “supported” by GIS clients so think it’s still good to have the disclaimer up front. I did add a red circle and made the image smaller, though.
Fine by me.
As I mentioned in GIBS-4828: “I may need to work with @mcechini to see which endpoint the GIS clients are actually requesting… e.g. are they requesting tiles in EPSG:4326 and reprojecting them client-side or are they requesting them in EPSG:3857. Or does it not matter?”
Ah I think these screen captures were carryovers from earlier when we didn’t have hierarchical WMS. I've updated them now.
Done
Actually there’s now a nice button to check that next to each temporally-enabled layer. I’ve added a note and screen caps about it to the docs.
Done
See above
That should be a really straightforward thing to do so will omit for now.
Done
Per another comment I made in GIBS-4828, we may want to list the WMS endpoints elsewhere in the docs and link to them from here rather than listing them out in each section
I’m not sure that I have a working copy of this anymore as it’s relatively deprecated with ArcGIS Pro being the preferred option AFAIK
Same comment above about deprecation but could be good to include in ArcGIS Pro assuming it works there
See above
See above
The hierarchy doesn't appear to be available in the current version of AGOL
Done
Let's see what happens in future versions of AGOL and update our docs at that point
See above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. A few remaining items to discuss, but we can handle that in the GIBS ticket.
No description provided.