Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add follow up style additions #5

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Add follow up style additions #5

merged 3 commits into from
Aug 19, 2021

Conversation

Benjaki2
Copy link
Collaborator

@Benjaki2 Benjaki2 commented Aug 17, 2021 •
edited
Loading

Fixes #3

  • Add Admonitions
  • Allow custom attributes
  • Show TOC nested item on load from hash

Ben added 2 commits August 16, 2021 17:36
Add extensions #3
a549d14 
* Add Admonitions
* Allow custom attributes
fix initial load nested toc #3
3229471
@Benjaki2 Benjaki2 marked this pull request as ready for review August 17, 2021 21:15
rboller
rboller approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@rboller rboller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look great to me, thanks for the updates!

minniewong
minniewong approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Benjaki2 Benjaki2 merged commit 3f1974d into split-documentation-rtd Aug 19, 2021
@Benjaki2 Benjaki2 deleted the split-documentation-rtd-follow-up branch August 19, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboller rboller rboller approved these changes

@minniewong minniewong minniewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Benjaki2 @rboller @minniewong