Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-2161: Updating Catalog Table Headers #20

Merged
merged 3 commits into from
Jun 14, 2023
Merged

WV-2161: Updating Catalog Table Headers #20

merged 3 commits into from
Jun 14, 2023

Conversation

ryanweiler92
Copy link
Collaborator

@ryanweiler92 ryanweiler92 commented Jun 5, 2023

Some of the layers in the layer catalog were displaying 'daily' temporal periods which was misleading. This updates all layers to use the 'layerPeriod' property of the metadata in the period column of the layer catalog table. This means that 8-day products will display '8-day' in this column instead of 'Daily'.

This also moves the temporal range column in the layer catalog column headers next to the period column.

How to test:

  1. Ensure that the necessary python dependencies from the readme are installed.
  2. Open a terminal and cd into your repo.
  3. mkdocs serve
  4. Open the available-visualizations page.
  5. Find the 'Leaf Area Index' group and verify that the 'Period' column for each layer displays either '8-Day' or '4-Day'.
  6. Also verify that the 'Period' column and the 'Temporal Range' column are side by side.

@ryanweiler92 ryanweiler92 self-assigned this Jun 5, 2023
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This wouldn't overwrite Tom's previously merged PR, right?

Copy link
Contributor

@Tomcariello Tomcariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I think we should merge main into this branch as @minniewong suggested.

@ryanweiler92 ryanweiler92 merged commit fd1b4cd into main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants