Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hopefully final updates #11

Merged
merged 10 commits into from
Jan 27, 2022
Merged

hopefully final updates #11

merged 10 commits into from
Jan 27, 2022

Conversation

mcechini
Copy link
Contributor

No description provided.

minniewong
minniewong requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions in the ticket.

rboller
rboller requested changes Dec 23, 2021
View reviewed changes
Copy link
Member

@rboller rboller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my suggested updates to the ticket.

mcechini and others added 7 commits January 7, 2022 09:29
@mcechini
content updates after Ryan's comments
a6e3280
@mcechini
renaming files to match heading 1
2c9f410
@mcechini
updating 3857 TWMS KVP example
4a45101
@rboller
Minor updates to text and fixed a few broken links
ae25e0b
@rboller
Added note about using EPSG:4326 for hierarchical WMS listings; updat…
a58863f 
…ed formatting of ArcGIS Pro section
@mcechini
Merge branch 'main' into gibs-4829-content-update
7daa8a4 
# Conflicts:
#	docs/visualization-layers.md
@mcechini
Merged in main.
83a26e8 
Fixed the missing `[4]` footnote in the table
Added text prior to the dynamic table for context
Changed `Categories` to `Science Disciplines` in the table filter to a) match Worldview terminology and b) deconflict with the "Categories" addressed earlier in the page
Cleaned up "geographic projection" to "map projection" where needed
rboller
rboller approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@rboller rboller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick scan through all of the pages and they look good to me.

minniewong
minniewong approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@minniewong minniewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing i would complain about is that i think the GIS images are too big, but then it's readable, so they should stay as is :)

@mcechini mcechini merged commit 252cf8e into main Jan 27, 2022
@mcechini mcechini deleted the gibs-4829-content-update branch January 27, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboller rboller rboller approved these changes

@minniewong minniewong minniewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcechini @rboller @minniewong