Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-1959: available layers #10

Merged
merged 10 commits into from
Dec 15, 2021
Merged

WV-1959: available layers #10

merged 10 commits into from
Dec 15, 2021

Conversation

jasontk19
Copy link
Collaborator

This is still a work in progress but, since the basic foundation is in place, it could be easier to go ahead and merge this (pending review) to allow easier access for stakeholders to provide feedback.

@jasontk19 jasontk19 self-assigned this Dec 13, 2021
- build groupings on measurements
- use live prod wv.json
- fix resolution/proj display issues
Copy link
Collaborator

@Benjaki2 Benjaki2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Though I would consider using a local version of Vue instead of pulling from the CDN.

@jasontk19
Copy link
Collaborator Author

Looks good! Though I would consider using a local version of Vue instead of pulling from the CDN.

Meaning just locally keep a minified copy in this repo right? I'd be down for that. Definitely wanted to avoid adding a whole build process with webpack etc.

Why not the CDN though, just limiting an external dependency on another service?

@Benjaki2
Copy link
Collaborator

Looks good! Though I would consider using a local version of Vue instead of pulling from the CDN.

Meaning just locally keep a minified copy in this repo right? I'd be down for that. Definitely wanted to avoid adding a whole build process with webpack etc.

Why not the CDN though, just limiting an external dependency on another service?

Yep. Exactly my thinking.

@jasontk19 jasontk19 merged commit d5541d0 into main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants