Skip to content

Commit

Permalink
Update Dockerfiles for python artifacts to use latest git version
Browse files Browse the repository at this point in the history
Due to a recent change (Feb 2018) in Github's policy to discontinue
support for weak cryptographic standards, older git versions stopped
working with Github repositories. The Dockerfiles for building python
artifacts currently uses git 2.0.5, that fails with an error `tlsv1
alert protocol version`.

The CentOS image by the latest source Dockerfile, `manylinux` comes
with the latest version of git as well, removing the need to manually
build git from source.
  • Loading branch information
ghostwriternr committed Mar 4, 2018
1 parent 6eae794 commit 89ce16b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
13 changes: 0 additions & 13 deletions tools/dockerfile/grpc_artifact_python_manylinux_x64/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,6 @@ FROM quay.io/pypa/manylinux1_x86_64
# Update the package manager
RUN yum update -y

#############################################################
# Update Git to allow cloning submodules with --reference arg
RUN yum remove -y git
RUN yum install -y curl-devel expat-devel gettext-devel linux-headers openssl-devel zlib-devel gcc
RUN cd /usr/src && \
curl -O -L https://kernel.org/pub/software/scm/git/git-2.0.5.tar.gz && \
tar xzf git-2.0.5.tar.gz
RUN cd /usr/src/git-2.0.5 && \
make prefix=/usr/local/git all && \
make prefix=/usr/local/git install
ENV PATH /usr/local/git/bin:$PATH
RUN source /etc/bashrc

###################################
# Install Python build requirements
RUN /opt/python/cp27-cp27m/bin/pip install cython
Expand Down
13 changes: 0 additions & 13 deletions tools/dockerfile/grpc_artifact_python_manylinux_x86/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,6 @@ FROM quay.io/pypa/manylinux1_i686
# Update the package manager
RUN yum update -y

#############################################################
# Update Git to allow cloning submodules with --reference arg
RUN yum remove -y git
RUN yum install -y curl-devel expat-devel gettext-devel linux-headers openssl-devel zlib-devel gcc
RUN cd /usr/src && \
curl -O -L https://kernel.org/pub/software/scm/git/git-2.0.5.tar.gz && \
tar xzf git-2.0.5.tar.gz
RUN cd /usr/src/git-2.0.5 && \
make prefix=/usr/local/git all && \
make prefix=/usr/local/git install
ENV PATH /usr/local/git/bin:$PATH
RUN source /etc/bashrc

###################################
# Install Python build requirements
RUN /opt/python/cp27-cp27m/bin/pip install cython
Expand Down

0 comments on commit 89ce16b

Please sign in to comment.