Skip to content

Commit

Permalink
Address reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vjpai committed Mar 3, 2018
1 parent 162ae4f commit 4013f0c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/core/lib/gprpp/thd.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class ThreadInternalsInterface {
virtual void Join() GRPC_ABSTRACT;
GRPC_ABSTRACT_BASE_CLASS
};

} // namespace internal

class Thread {
Expand Down Expand Up @@ -98,9 +99,9 @@ class Thread {
GPR_ASSERT(state_ == FAILED);
}
};

void Join() {
if (impl_ != nullptr) {
GPR_ASSERT(state_ == STARTED);
impl_->Join();
grpc_core::Delete(impl_);
state_ = DONE;
Expand Down

0 comments on commit 4013f0c

Please sign in to comment.