Clean up grpc_py_binary build rule

narzolliam · Mar 6, 2018 · 092f199 · 092f199
1 parent 6eae794
commit 092f199
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/bazel/grpc_build_system.bzl b/bazel/grpc_build_system.bzl
@@ -170,17 +170,13 @@ def grpc_sh_binary(name, srcs, data = []):
  srcs = srcs,
  data = data)
 
-def grpc_py_binary(name, srcs, data = [], deps = []):
- if name == "test_dns_server":
- deps = _get_external_deps([
- "twisted",
- "yaml",
- ])
+def grpc_py_binary(name, srcs, data = [], deps = [], external_deps = [], testonly = False):
  native.py_binary(
  name = name,
  srcs = srcs,
  data = data,
- deps = deps)
+ deps = deps + _get_external_deps(external_deps)
+ )
 
 def grpc_package(name, visibility = "private", features = []):
  if visibility == "tests":

diff --git a/test/cpp/naming/BUILD b/test/cpp/naming/BUILD
@@ -37,10 +37,11 @@ grpc_sh_binary(
 grpc_py_binary(
  name = "test_dns_server",
  srcs = ["test_dns_server.py"],
+ testonly = True,
  data = [
  "resolver_test_record_groups.yaml",
  ],
- deps = [
+ external_deps = [
  "twisted",
  "yaml",
  ]