Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use webview.dll #21

Merged
merged 4 commits into from
Feb 10, 2023
Merged

use webview.dll #21

merged 4 commits into from
Feb 10, 2023

Conversation

konovod
Copy link
Contributor

@konovod konovod commented Feb 9, 2023

This is a questionable change, but i don't think that linking WebView2 statically on Windows is possible right now.
Crystal compiler uses MSVC linker, so current flags just don't work.

@naqvis
Copy link
Owner

naqvis commented Feb 9, 2023

Thanks @konovod . Dynamic linking is okay, but would be better if either a script is provided to download the webview.dll and/or its dependencies or the steps that are required to download the dependencies for user to get this working on Windows.

I don't have access to windows box , so would appreciate your help in ensuring the steps and changes provided in this PR are working fine on Windows.

@konovod
Copy link
Contributor Author

konovod commented Feb 10, 2023

About acquiring dll:
Sadly webview don't provide binary releases. I've made a fork of webview and changed CI there to provide downloadable dll : https://github.com/konovod/webview/actions/runs/4083863284 but forking isn't a right way.

I've tried to follow instructions from https://github.com/webview/webview : basically git clone https://github.com/webview/webview and then webview\script\build.bat. Surprisingly it worked, so perhaps it's a best way.

I've added installation instructions to this PR.

@naqvis
Copy link
Owner

naqvis commented Feb 10, 2023

Thanks @konovod. Can you please also bump version in shard.yml and src/webview.cr so that new release can be made after this PR is merged.

@konovod
Copy link
Contributor Author

konovod commented Feb 10, 2023

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants