Skip to content

Commit

Permalink
bitesize: switch to issue tracepoint (iovisor#2283)
Browse files Browse the repository at this point in the history
bitesize: switch to trace_block_rq_issue tracepoint
  • Loading branch information
brendangregg authored and yonghong-song committed Mar 21, 2019
1 parent 92f824c commit 6b05e61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion man/man8/bitesize.8
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ bitesize \- Summarize block device I/O size as a histogram \- Linux eBPF/bcc.
.SH DESCRIPTION
Show I/O distribution for requested block sizes, by process name.

This works by tracing block:block_rq_insert and prints a historgram of I/O size.
This works by tracing block:block_rq_issue and prints a historgram of I/O size.

Since this uses BPF, only the root user can use this tool.
.SH REQUIREMENTS
Expand Down
2 changes: 1 addition & 1 deletion tools/bitesize.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
BPF_HISTOGRAM(dist, struct proc_key_t);
TRACEPOINT_PROBE(block, block_rq_insert)
TRACEPOINT_PROBE(block, block_rq_issue)
{
struct proc_key_t key = {.slot = bpf_log2l(args->bytes / 1024)};
bpf_probe_read(&key.name, sizeof(key.name), args->comm);
Expand Down

0 comments on commit 6b05e61

Please sign in to comment.