Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence NNI_ASSERT warnings when building with NDEBUG (#1621) #1622

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Silence NNI_ASSERT warnings when building with NDEBUG (#1621) #1622

merged 1 commit into from
Oct 19, 2022

Conversation

L0PiTaL
Copy link
Contributor

@L0PiTaL L0PiTaL commented Sep 27, 2022

fixes #1621 Silence NNI_ASSERT warnings

shikokuchuo
shikokuchuo reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@shikokuchuo shikokuchuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to this independently (somehow at the same time) and support this change so the library compiles without warnings with -DCMAKE_BUILD_TYPE=Release

@gdamore gdamore mentioned this pull request Oct 17, 2022
Closed
@gdamore gdamore merged commit 5385b78 into nanomsg:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikokuchuo shikokuchuo shikokuchuo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning when building with NDEBUG
3 participants
@L0PiTaL @shikokuchuo @gdamore