fixes issue #1543 - Deadlock in nng_close(socket) #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nanomsg#1543 by aborting tasks that may have been prepped, but not yet started.
|
At first blush it looks good. Thanks for digging into this.. it was not easy to debug this I suspect. I want to make sure runs are good and would like to do a little deeper analysis just be 100% certain, but I'm pretty sure this is an excellent fix. |
|
I can't seem to restart the workflow on this. Probably because it is so old. I'm going to just merge it. If there are problems I may back it out, but I don't expect that to be needed. |
|
So I'm going to have to back this change out it appears. The change introduces other crashes in the test suite. I'm going to see if I can better understand it. |
|
thanks @gdamore, sorry for the trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1543 by aborting tasks that may have been prepped, but not yet started. otherwise on a socket close the reap thread can get stuck waiting for the task to start/finish.