Fix mingw atomics #1601
Merged
Fix mingw atomics #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the build error: "InterlockedDecrementAcquire64 not defined" on Mingw
From Microsoft docs, InterlockedDecrementRelease64 returns the resulting decremented value. The equivalent function on Mingw is `__atomic_sub_fetch`, not `__atomic_fetch_sub` (which returns the previous value).
|
Oops, thanks for fixing this. It's unfortunate that mingw needs these special handling cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with Mingw atomics defines which are solved by this PR's commits:
InterlockedDecrementAcquire64was not defined, so the build failed on Mingw.InterlockedDecrementRelease64was incorrect. The docs for this function state that"The function returns the resulting decremented value."
The equivalent function for this in Mingw is
__atomic_sub_fetch, and not__atomic_fetch_sub(which returns the value previous to the decrement).