Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1590 Undefined reference to nni_atomic_dec & nni_atomic_dec64 on Windows. #1591

Merged
merged 1 commit into from
May 30, 2022
Merged

fixes #1590 Undefined reference to nni_atomic_dec & nni_atomic_dec64 on Windows. #1591

merged 1 commit into from
May 30, 2022

Conversation

alvin1221
Copy link
Contributor

fixes #1590

@gdamore
Copy link
Contributor

gdamore commented May 30, 2022

This looks good... sorry I somehow missed this. I am guessing you're using this in your own code, because there are no callers for these APIs in the NNG code itself.

(Note that the atomic functions are not public.)

@gdamore gdamore merged commit 5f6127f into nanomsg:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined reference to nni_atomic_dec & nni_atomic_dec64 on Windows.
2 participants
@alvin1221 @gdamore