Improved error handling in message parser #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, This improves the errors generated from message_parser |
clemahieu
pushed a commit
that referenced
this pull request
Mar 8, 2018
* Fix typos (#683) * Move to C++14 Replaces a single reset with make_unique to see if things compile in CI. Also reverts a CI-specific RPATH change which prevented the wallet from running on macOS dev machines * Update CMakeLists.txt to support gtest linking for Windows * Fix test for wallet_create_max to allow for utx database addition (#691) * Remove unused code (#686) * Fix docker boost url * Revert nonWalletDbs Revert to fix failing tests * Improved error handling in message parser (#704) * Replacing bool get_optional with get default values (#670) * Revert "Watch only accounts" This reverts commit 1b0809a. * Replacing bool get_optional with get default values * RPC tests for optional bool values * RPC tests for wallet_ledger & wallet_add_watch * Improve account history RPC endpoint (#668) * Checking ledger::forked_block preconditions which were asserting. * Update README (#709) * update docs to add guides and update "what is nano?" system * add whitepaper to guides and docs * update features list * update what is nano header level * Build of Boost Cleanup (#707) * Updated to check the boost SHA256 when downloading * Fixed invalid shell option * Allow the user to request a minimal build of Boost * Ensure boost build script exits on error * Removed apparently unused "mkdir" * Docker altnets (#708) * Updated to check the boost SHA256 when downloading * Fixed invalid shell option * Allow the user to request a minimal build of Boost * Ensure boost build script exits on error * Removed apparently unused "mkdir" * Updated Docker build for node to support altnets * Allow user-supplied arguments to "docker build" * Updated Docker auto deploy to build a live and beta image for each tag * Print the correct image name when building the docker image * Corrected typo for the test network * Broadcasting active elections blocks to discovered representatives (#711) * Broadcasting active elections blocks * Improve formatting for clang * Connecting to rai-beta for beta network. * Specify beta network representatives (#712) * Update the beta network configuration (#713) * Specify beta network representatives * Update beta network genesis block * Use port 54000 for beta nodes * Add history RPC raw support to ublocks * Fix test for wallet_create_max to allow for utx database addition (#691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communicates errors from message_parser to the node more precisely so errors can be logged.