-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping GLM as a dependency, if possible. #130
Comments
Oh gosh that sucks, if the license allows, I don't mind including the glm files in slop. Or some math lib replacement. |
The license is "GLM is licensed under The Happy Bunny License or MIT License" so it'd probably be fine to pick the MIT license and include it in slop's sources. Getting slop to build in this way was easier than I thought. Here's what works for me (with glm's unmodified source in #!/bin/sh -e
export DESTDIR="$1"
(
cd glm
cmake -B build \
-DCMAKE_INSTALL_PREFIX=/usr \
-DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_BUILD_TYPE=Release \
-DSLOP_OPENGL=False
cmake --build build
)
# Required files from glm are in `./glm/glm` so we only need to
# point slop to `./glm` as the includes are all `<glm/blabla>`
cmake -B build \
-DGLM_INCLUDE_DIR="$PWD/glm" \
-DCMAKE_INSTALL_PREFIX=/usr \
-DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_BUILD_TYPE=Release \
-DSLOP_OPENGL=False
cmake --build build
cmake --install build I'd be happy to send a PR your way if you're interested in making this change. 👍 |
Rationale: - #1071 - naelstrof/slop#130
Rationale: - dylanaraps#1071 - naelstrof/slop#130
I don't know how much slop actually makes use of this library, but dropping it if possible might be a good idea if this is possible? I saw you talked about the possibility of using in-house math over glm in a previous issue. Reasons:
Since version
0.9.9.5
, glm has been very hard for distros to package, because the developer removed the cmake files, I would link you various issues, but the glm dev nuked his issue tracker, more about that later. For now, instead see the archPkgfile
for example: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/glm#n30With hacky hacks it is possible to circumvent this problem (again, see the Arch
Pkgfile
), though the majority of distros seems to stay at0.9.9.5
(rather than0.9.9.8
, the newest version.) This in itself would not be a huge problem, but there is more: since this week, the GLM developer simply nuked the bug tracker, and removed ALL issues...In short:
The text was updated successfully, but these errors were encountered: