Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Use workflowHelpers.getWebhookUrl to determine webhook/form test URL (no-changelog) #9977

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 9, 2024

Summary

All frontend code that needs to determine a webhook or form url should always use workflowHelpers.getWebhookUrl.

Related Linear tickets, Github issues, and Community forum posts

Fixes #9975
NODE-1488

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 9, 2024
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

cypress bot commented Jul 9, 2024

5 flaky tests on run #5843 ↗︎

0 399 0 0 Flakiness 5

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 4dff41d64b
Status: Passed Duration: 05:11 💡
Started: Jul 9, 2024 11:54 AM Ended: Jul 9, 2024 11:59 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > Node hover actions > should execute node Test Replay Screenshots Video

Review all test suite changes for PR #9977 ↗︎

Copy link
Contributor

github-actions bot commented Jul 9, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 058ae5d into master Jul 9, 2024
28 checks passed
@netroy netroy deleted the fix-NODE-1488-form-test-url branch July 9, 2024 12:15
netroy added a commit that referenced this pull request Jul 9, 2024
ivov pushed a commit that referenced this pull request Jul 10, 2024
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with [email protected]

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug? Cannot dynamically set Form Path for Form Trigger
3 participants