refactor(editor): Add types to global link actions event bus (no-changelog) #10452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5213f5d
to
3fe4ab8
Compare
alexgrozav
reviewed
Aug 16, 2024
alexgrozav
previously approved these changes
Aug 16, 2024
|
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
alexgrozav
reviewed
Aug 19, 2024
alexgrozav
approved these changes
Aug 19, 2024
|
|
Also rename the file to correspond the event bus name.
Co-authored-by: Alex Grozav <[email protected]>
daae677
to
c49c6a6
Compare
|
@alexgrozav could you reapprove? Had to rebase to master to get the tests pass |
alexgrozav
approved these changes
Aug 20, 2024
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 21, 2024
* master: fix(core): Replace `sanitize-html` with `xss` in XSS validator constraint (#10479) refactor(core): Track metrics state and categories in telemetry (no-changelog) (#10483) fix: Rename Assistant back (#10481) test(editor): Add AI Assistant e2e tests (no-changelog) (#10476) feat(core): Support bidirectional communication between specific mains and specific workers (#10377) refactor(editor): Add types to global link actions event bus (no-changelog) (#10452)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add types to global link actions event bus. Also rename the file to correspond the event bus name.
Related Linear tickets, Github issues, and Community forum posts
CAT-32
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)