Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compile dependencies on CI #2394

Closed
azzamsa opened this issue Jun 22, 2024 · 0 comments · Fixed by #2429
Closed

Don't compile dependencies on CI #2394

azzamsa opened this issue Jun 22, 2024 · 0 comments · Fixed by #2429

Comments

@azzamsa
Copy link
Contributor

azzamsa commented Jun 22, 2024

Hi, 👋

Compiling cross on CI takes more time compared to pulling the binary directly from a GitHub release.

We can use taiki-e/install-action to pull the binary directly from the GitHub release. This action supports tagging a specific release or using the latest version.

modified   .github/workflows/ci.yml
@@ -56,9 +56,7 @@ jobs:
-    - name: Install cross
-      # See https://github.com/cross-rs/cross/issues/1222
-      run: cargo install cross --git https://github.com/cross-rs/cross
+    - uses: taiki-e/install-action@cross

However, I see that the CI currently pulls from the latest commit with --git, which requires compiling.
If you prefer using the latest release, I am ready to make a PR to switch to taiki-e/install-action.

Thank you for Iroh 🍜
@azzamsa azzamsa mentioned this issue Jun 29, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
@azzamsa @Arqu
chore(ci): use pre-compiled binary on CI (#2429)
cdad25a 
## Description

Quoting from #2394 

> Compiling `cross` on CI takes more time compared to pulling the binary
directly from a GitHub release.

> We can use
[taiki-e/install-action](https://github.com/taiki-e/install-action) to
pull the binary directly from the GitHub release. This action supports
tagging a specific release or using the latest version.

## Breaking Changes

No.

## Notes & open questions


## Change checklist

- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.

Closes #2394

Co-authored-by: Asmir Avdicevic <[email protected]>
@Arqu Arqu closed this as completed in #2429 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): use pre-compiled binary on CI azzamsa/iroh
1 participant
@azzamsa