Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: test_default_author_persist #2380

Closed
flub opened this issue Jun 18, 2024 · 1 comment
Closed

Flaky test: test_default_author_persist #2380

flub opened this issue Jun 18, 2024 · 1 comment
Assignees
@Frando
Labels
flaky-test

Comments

@flub
Copy link
Contributor

flub commented Jun 18, 2024

thread 'node::tests::test_default_author_persist' panicked at iroh/src/node.rs:482:14:
called Result::unwrap() on an Err value: Database already open. Cannot acquire lock.

https://github.com/n0-computer/iroh/actions/runs/9564905791/job/26366683627
@flub flub mentioned this issue Jun 18, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 18, 2024
@flub
tests(iroh-net): Remove a flaky test (#2379)
d37a4a4 
## Description

This flakyness seems to have been successfully addressed by the
staggered DNS lookup.  Converting this test to that basically results
in the same code as the next test: test_dns_lookup_ipv4_ipv6.  So just
remove this test as it no longer provides value.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

See #2380 for the flaky test.

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- [x] Tests if relevant.
- ~~[ ] All breaking changes documented.~~
ppodolsky pushed a commit to izihawa/iroh that referenced this issue Jun 22, 2024
@flub @ppodolsky
tests(iroh-net): Remove a flaky test (n0-computer#2379)
9ae63b8 
## Description

This flakyness seems to have been successfully addressed by the
staggered DNS lookup.  Converting this test to that basically results
in the same code as the next test: test_dns_lookup_ipv4_ipv6.  So just
remove this test as it no longer provides value.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

See n0-computer#2380 for the flaky test.

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- [x] Tests if relevant.
- ~~[ ] All breaking changes documented.~~
@Frando
Copy link
Member

Frando commented Jul 3, 2024 •
edited
Loading

Fixed in #2390 (hopefully)

@Frando Frando closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frando Frando

Labels
flaky-test
Projects
iroh
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frando @flub