Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relay HTTP handler to be served on /relay #2378

Closed
flub opened this issue Jun 18, 2024 · 3 comments · Fixed by #2419
Closed

Move relay HTTP handler to be served on /relay #2378

flub opened this issue Jun 18, 2024 · 3 comments · Fixed by #2419

Comments

@flub
Copy link
Contributor

flub commented Jun 18, 2024

Currently the relay HTTP handler is served on /derp. We should transition that to /relay before we stabilise the wire protocol. But we want to coordinate this as it is a breaking wire-level change.

@matheus23
Copy link
Contributor

We can start supporting both options and use /relay in the client immediately and then later coordinate the breaking change.

@DAOCUONG
Copy link

Can you explain why we remove derp option we are facing problem today our peer can not connect because iroh server is shutting down

@flub
Copy link
Contributor Author

flub commented Jun 21, 2024

Can you explain why we remove derp option we are facing problem today our peer can not connect because iroh server is shutting down

Could you please open a new issue for your problem and describe exactly what happened and maybe provide logs to show how it looked as well?

We're not removing anything in this issue, we are renaming things from "derp" to "relay" and the URL endpoint is one of the things we want to rename.

github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
… `/derp` route to `/relay` (#2419)

## Description

- Removes `relay_endpoint` config option from `ServerBuilder`
- Makes `iroh-relay` accept both `/derp` and `/relay` as paths for
relaying
- Makes `/relay` the default path used in the iroh-net client

TODO:
- [x] Test both URLs

## Breaking Changes

- `iroh_net::relay::http::ServerBuilder`: Removed `relay_endpoint`
function

## Notes & open questions

Closes #2378 

✅ Merge this after #2387 

## Change checklist

- [X] Self-review.
- [X] Documentation updates if relevant.
- [X] Tests if relevant.
- [X] All breaking changes documented.
matheus23 added a commit that referenced this issue Jul 11, 2024
…f `/derp` (#2441)

Split out from #2419 

Splitting this out means we can deploy the relay changes one release in
advance to the changes in the client.

Otherwise, we'd need to update the relays ASAP when we release 0.20, as
clients will expect to be able to connect to the `/relay` route (which
may not be deployed immediately after the release).

## Description

- Switches the client to connect to `/relay` instead of `/derp`.

## Breaking Changes

None

## Notes & open questions

Also a PR related to #2378 

I allowed myself to add in another `derive_more::Debug` instance instead
of a custom, outdated `impl Debug`, if that's okay with you 😁

## Change checklist

- [X] Self-review.
- [X] Documentation updates if relevant.
- [X] Tests if relevant.
- [X] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants