Support compressed ssl sockets #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vykulakov
requested changes
Jan 17, 2023
Refactored transports to implement net.Conn interface, this makes it possible to use the zlib as an underlying transport for TLS. re-ordered the client transport stack to have the buffered transport on top as it would otherwise conflict with the TLS transport New order of transports (ordered from TCP connection to library exposed) * TCP socket connection * Compression (if compression level > 0) * TLS (if TLSConfig is set) * Buffer (if BufferSize > 0)
vykulakov
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avro handles compression over ssl in a quite odd way.
Normally when you do compression and ssl for writes you would first do compression then encryption
Avro does it the other way around, first encryption then compression.