Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract network connection things to a separated struct #4

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Extract network connection things to a separated struct #4

merged 2 commits into from
Dec 16, 2019

Conversation

vykulakov
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Pull Request Test Coverage Report for Build f6e0c72cd8f81fa21dedc32858ea8e665a8c5952-PR-4

  • 38 of 48 (79.17%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.6%) to 47.333%
Changes Missing Coverage Covered Lines Changed/Added Lines %
socket.go 38 41 92.68%
client.go 0 7 0.0%
Totals Coverage Status
Change from base Build 2ae469657e8e27e25c3bd634b60c9e0defd30370: 7.6%
Covered Lines: 142
Relevant Lines: 300
💛 - Coveralls

@vykulakov vykulakov merged commit d8b46e6 into master Dec 16, 2019
@vykulakov vykulakov deleted the slava/socket branch December 16, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vykulakov