Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffered transport, close #13 #14

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Conversation

vykulakov
Copy link
Collaborator

No description provided.

@vykulakov
Copy link
Collaborator Author

Using compression with buffer:
image

Using compression without buffer:
image
On the second screenshot, ten or more lines are not shown.

So buffering makes things much better.

@vykulakov
Copy link
Collaborator Author

The same result can be observed without data compression. It happens because of the framing layer: it creates and writes immediately to a socket frame serials, frame sizes, number of frames, frame content and so on. And it results in many separated network requests.

@vykulakov vykulakov merged commit c5e86f6 into master Dec 22, 2019
@vykulakov vykulakov deleted the slava/buffered_transport branch December 22, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant