Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace issues as well as issue #28 #31

Merged
merged 4 commits into from
Jun 27, 2015

Conversation

erikmd
Copy link
Contributor

@erikmd erikmd commented Jun 21, 2015

Hello,

I would like to propose some minor fixes, regarding whitespaces issues in org-gcal.el.

This pull request also fixes #28 (following this comment).
However, I did not include in this pull request the other change suggested in that comment (cf. erikmd/org-gcal.el@41c8529), given that the expression (expand-file-name (concat (file-name-directory (locate-library "org-gcal")) org-gcal-logo) could just as well point to some non-writable directory, such as /usr/share/sth...

Best regards.

@erikmd
Copy link
Contributor Author

erikmd commented Jun 21, 2015

FYI: I have just pushed a new version of the PR (after rebasing).

@myuhe
Copy link
Owner

myuhe commented Jun 27, 2015

Sorry for late reply.
Thanks 👍

myuhe added a commit that referenced this pull request Jun 27, 2015
Fix whitespace issues as well as issue #28
@myuhe myuhe merged commit 1fe5817 into myuhe:master Jun 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deferred error : (text-read-only)
2 participants