Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default_settings.py and rename SCRAPYD_LOGS_DIR #79

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Aug 3, 2019

No description provided.

@pep8speaks
Copy link

Hello @my8100! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 66:121: E501 line too long (158 > 120 characters)

Line 68:110: E226 missing whitespace around arithmetic operator

@coveralls
Copy link

coveralls commented Aug 3, 2019

Pull Request Test Coverage Report for Build 195

  • 25 of 28 (89.29%) changed or added relevant lines in 7 files are covered.
  • 36 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 87.598%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/run.py 0 1 0.0%
scrapydweb/views/baseview.py 3 4 75.0%
scrapydweb/views/dashboard/jobs.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
scrapydweb/common.py 1 82.26%
scrapydweb/views/operations/deploy.py 1 88.74%
scrapydweb/views/dashboard/jobs.py 2 91.72%
scrapydweb/vars.py 4 91.3%
scrapydweb/utils/setup_database.py 28 43.0%
Totals Coverage Status
Change from base Build 184: -0.2%
Covered Lines: 3341
Relevant Lines: 3814

💛 - Coveralls

@my8100 my8100 merged commit 7ca184f into master Aug 3, 2019
@my8100 my8100 deleted the update_default_settings_py branch August 4, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants