Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pages for aggregating stats: Node Reports and Cluster Reports #75

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Jul 30, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jul 30, 2019

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 145:13: W503 line break before binary operator
Line 146:13: W503 line break before binary operator
Line 147:13: W503 line break before binary operator
Line 147:13: E129 visually indented line with same indent as next logical line
Line 270:13: W503 line break before binary operator
Line 270:13: E129 visually indented line with same indent as next logical line
Line 373:16: W503 line break before binary operator

Comment last updated at 2019-07-30 09:06:47 UTC

@coveralls
Copy link

coveralls commented Jul 30, 2019

Pull Request Test Coverage Report for Build 129

  • 150 of 164 (91.46%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 89.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/views/baseview.py 5 6 83.33%
scrapydweb/views/dashboard/cluster_reports.py 25 26 96.15%
scrapydweb/views/files/items.py 0 1 0.0%
scrapydweb/views/dashboard/node_reports.py 28 31 90.32%
scrapydweb/views/files/log.py 78 86 90.7%
Totals Coverage Status
Change from base Build 117: 0.4%
Covered Lines: 3278
Relevant Lines: 3679

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #75 into master will increase coverage by 0.29%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   88.85%   89.15%   +0.29%     
==========================================
  Files          30       32       +2     
  Lines        3554     3679     +125     
==========================================
+ Hits         3158     3280     +122     
- Misses        396      399       +3
Impacted Files Coverage Δ
scrapydweb/views/operations/schedule.py 98.23% <ø> (ø) ⬆️
scrapydweb/views/overview/servers.py 93.75% <ø> (ø) ⬆️
scrapydweb/views/files/items.py 51.28% <0%> (-1.35%) ⬇️
scrapydweb/views/files/logs.py 100% <100%> (ø) ⬆️
scrapydweb/__init__.py 95.9% <100%> (+0.17%) ⬆️
scrapydweb/views/dashboard/jobs.py 92.35% <100%> (ø)
scrapydweb/views/baseview.py 88.54% <83.33%> (-0.13%) ⬇️
scrapydweb/views/dashboard/node_reports.py 90.32% <90.32%> (ø)
scrapydweb/views/files/log.py 94.9% <90.69%> (+1.71%) ⬆️
scrapydweb/views/dashboard/cluster_reports.py 96.15% <96.15%> (ø)
... and 3 more

@my8100 my8100 merged commit 03934cc into master Jul 30, 2019
@my8100 my8100 deleted the add_reports_page branch July 30, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants