Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional "table already defined" in JobsView #68

Merged
merged 1 commit into from
Jul 13, 2019

Conversation

my8100
Copy link
Owner

@my8100 my8100 commented Jul 13, 2019

No description provided.

@pep8speaks
Copy link

Hello @my8100! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 111:80: E501 line too long (102 > 79 characters)

Line 171:80: E501 line too long (95 > 79 characters)
Line 303:80: E501 line too long (86 > 79 characters)
Line 308:80: E501 line too long (109 > 79 characters)
Line 348:80: E501 line too long (104 > 79 characters)

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #68 into master will decrease coverage by 0.25%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage    89.5%   89.24%   -0.26%     
==========================================
  Files          30       30              
  Lines        3543     3552       +9     
==========================================
- Hits         3171     3170       -1     
- Misses        372      382      +10
Impacted Files Coverage Δ
scrapydweb/views/overview/tasks.py 98.1% <ø> (ø) ⬆️
scrapydweb/vars.py 98.07% <100%> (+0.03%) ⬆️
scrapydweb/utils/check_app_config.py 84.93% <100%> (+0.32%) ⬆️
scrapydweb/views/overview/jobs.py 92.23% <80%> (-1.89%) ⬇️
scrapydweb/common.py 84.12% <0%> (-6.35%) ⬇️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 72

  • 15 of 17 (88.24%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 88.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/views/overview/jobs.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
scrapydweb/views/overview/jobs.py 6 91.59%
Totals Coverage Status
Change from base Build 55: -0.08%
Covered Lines: 3154
Relevant Lines: 3552

💛 - Coveralls

@my8100 my8100 merged commit 0492882 into master Jul 13, 2019
@my8100 my8100 deleted the fix_jobs_table_already_defined branch July 13, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants